commit 5bfa058e65897567889354d7eb34af2b93a20f18
author arikrupnik <ari@30pins.com> Wed Jun 06 23:42:38 2018 -0500
committer Fred Drake <fred@fdrake.net> Thu Jun 07 00:42:38 2018 -0400
tree fcbae0b123d4ad0a28db1bfb61bc9b77fc0452fd
parent 7c69c1c0fba8c1c8ff3969bce4c1135736a4cc58

bpo-33274: Compliance with DOM L1: return removed attribute (#7465)

* bpo-33274: Compliance with DOM L1: return removed attribute

* Update 2018-06-06-22-01-33.bpo-33274.teYqv8.rst

Lib/test/test_minidom.py

diff --git a/Lib/test/test_minidom.py b/Lib/test/test_minidom.py
index a2cc882..e91cdba 100644
--- a/Lib/test/test_minidom.py
+++ b/Lib/test/test_minidom.py
@@ -325,7 +325,7 @@
         node = child.getAttributeNode("spam")
         self.assertRaises(xml.dom.NotFoundErr, child.removeAttributeNode,
             None)
-        child.removeAttributeNode(node)
+        self.assertIs(node, child.removeAttributeNode(node))
         self.confirm(len(child.attributes) == 0
                 and child.getAttributeNode("spam") is None)
         dom2 = Document()

Lib/xml/dom/minidom.py

diff --git a/Lib/xml/dom/minidom.py b/Lib/xml/dom/minidom.py
index a5d813f..e44e04a 100644
--- a/Lib/xml/dom/minidom.py
+++ b/Lib/xml/dom/minidom.py
@@ -823,6 +823,7 @@
         # Restore this since the node is still useful and otherwise
         # unlinked
         node.ownerDocument = self.ownerDocument
+        return node
 
     removeAttributeNodeNS = removeAttributeNode