commit 5d695b6b7bcccf5f028cdacd986096de15bc0ca6
author Steve Dower <steve.dower@python.org> Mon Sep 09 06:48:22 2019 -0700
committer GitHub <noreply@github.com> Mon Sep 09 06:48:22 2019 -0700
tree 2f6d1cca58d355ad8b0f7c1ccdbd8220a0cb6d01
parent 5e053eb98eb0d65a8e0f00b3641f9907198aace3

bpo-37702: Fix SSL's certificate-store leak on Windows (GH-15632)

ssl_collect_certificates function in _ssl.c has a memory leak.
Calling CertOpenStore() and CertAddStoreToCollection(), a store's refcnt gets incremented by 2.
But CertCloseStore() is called only once and the refcnt leaves 1.

Modules/_ssl.c

diff --git a/Modules/_ssl.c b/Modules/_ssl.c
index 089aa3b..6f91b48 100644
--- a/Modules/_ssl.c
+++ b/Modules/_ssl.c
@@ -5581,6 +5581,7 @@
             if (result) {
                 ++storesAdded;
             }
+            CertCloseStore(hSystemStore, 0);  /* flag must be 0 */
         }
     }
     if (storesAdded == 0) {