commit 5e8ffe147710e449c2e935a4e2ff5cbd19828a8a
author Hai Shi <shihai1992@gmail.com> Mon May 04 21:31:38 2020 +0800
committer GitHub <noreply@github.com> Mon May 04 22:31:38 2020 +0900
tree 4faa5ee8ccbae4dc255e0a2d912b6e64602b0538
parent 846d8b28ab9bb6197ee81372820311c0abe509c0

bpo-39573: Use Py_IS_TYPE to check for types (GH-19882)

Objects/genericaliasobject.c

diff --git a/Objects/genericaliasobject.c b/Objects/genericaliasobject.c
index c06d79c..4d511a2 100644
--- a/Objects/genericaliasobject.c
+++ b/Objects/genericaliasobject.c
@@ -424,8 +424,8 @@
 static PyObject *
 ga_richcompare(PyObject *a, PyObject *b, int op)
 {
-    if (Py_TYPE(a) != &Py_GenericAliasType ||
-        Py_TYPE(b) != &Py_GenericAliasType ||
+    if (!Py_IS_TYPE(a, &Py_GenericAliasType) ||
+        !Py_IS_TYPE(b, &Py_GenericAliasType) ||
         (op != Py_EQ && op != Py_NE))
     {
         Py_RETURN_NOTIMPLEMENTED;

Objects/typeobject.c

diff --git a/Objects/typeobject.c b/Objects/typeobject.c
index c2ddc16..db0ae97 100644
--- a/Objects/typeobject.c
+++ b/Objects/typeobject.c
@@ -6306,7 +6306,7 @@
         stack[1] = other; \
         r = vectorcall_maybe(tstate, &op_id, stack, 2); \
         if (r != Py_NotImplemented || \
-            Py_TYPE(other) == Py_TYPE(self)) \
+            Py_IS_TYPE(other, Py_TYPE(self))) \
             return r; \
         Py_DECREF(r); \
     } \