| commit | 65e5399081e23d7b1efbf685096c65d0a0ab912b | [log] [tgz] |
|---|---|---|
| author | Guido van Rossum <guido@python.org> | Thu Mar 26 22:12:22 1998 +0000 |
| committer | Guido van Rossum <guido@python.org> | Thu Mar 26 22:12:22 1998 +0000 |
| tree | 01e6410fbc78bdbcdc684e004b032fc37d995813 | |
| parent | 3ec38f0ee48b31c80510c60b3df0e6bc4dfb89f9 [diff] [blame] |
Don't write "if self.dict: self.dict.close()"; just write "self.dict.close()" and ignore the exception. The "if self.dict:" part would be calculated through len(self.dict.keys()), which is very expensive for a large dictionary...
diff --git a/Lib/shelve.py b/Lib/shelve.py index 9b65a09..6bdc030 100644 --- a/Lib/shelve.py +++ b/Lib/shelve.py
@@ -75,8 +75,7 @@ def close(self): try: - if self.dict: - self.dict.close() + self.dict.close() except: pass self.dict = 0