commit 6877111648ac3e042ee5d0458cbeb65dd1a84b2d
author Christian Heimes <christian@python.org> Tue Sep 05 21:55:40 2017 -0700
committer GitHub <noreply@github.com> Tue Sep 05 21:55:40 2017 -0700
tree c1e843cdc84d478c6ae396e892c274392e84c95e
parent 3463ee3972e0d14351ee18bce60ecfbf7ac96772

bpo-29781: Fix SSLObject.version before handshake (#3364)

SSLObject.version() now correctly returns None when handshake over BIO has
not been performed yet.

Signed-off-by: Christian Heimes <christian@python.org>

Modules/_ssl.c

diff --git a/Modules/_ssl.c b/Modules/_ssl.c
index b001bca..2fa6bd2 100644
--- a/Modules/_ssl.c
+++ b/Modules/_ssl.c
@@ -1706,6 +1706,10 @@
 
     if (self->ssl == NULL)
         Py_RETURN_NONE;
+    if (!SSL_is_init_finished(self->ssl)) {
+        /* handshake not finished */
+        Py_RETURN_NONE;
+    }
     version = SSL_get_version(self->ssl);
     if (!strcmp(version, "unknown"))
         Py_RETURN_NONE;