commit 6921c13bbbb2c9695edd87331d98f7aa1e48f7f2
author Raymond Hettinger <python@rcn.com> Sat Mar 21 02:03:40 2015 -0700
committer Raymond Hettinger <python@rcn.com> Sat Mar 21 02:03:40 2015 -0700
tree 61ae803a71c58b7306775afb8f73aef6e6ebe939
parent ac13ad6a32e5c130de91fc2038de9b1c265b3fe9

Minor nit.  Make the rotate() success/fail tests consistent.

Modules/_collectionsmodule.c

diff --git a/Modules/_collectionsmodule.c b/Modules/_collectionsmodule.c
index 28aacc3..b831627 100644
--- a/Modules/_collectionsmodule.c
+++ b/Modules/_collectionsmodule.c
@@ -634,7 +634,7 @@
 
     if (!PyArg_ParseTuple(args, "|n:rotate", &n))
         return NULL;
-    if (_deque_rotate(deque, n) == 0)
+    if (!_deque_rotate(deque, n))
         Py_RETURN_NONE;
     return NULL;
 }
@@ -864,7 +864,7 @@
         if (cmp > 0) {
             PyObject *tgt = deque_popleft(deque, NULL);
             assert (tgt != NULL);
-            if (_deque_rotate(deque, i) == -1)
+            if (_deque_rotate(deque, i))
                 return NULL;
             Py_DECREF(tgt);
             Py_RETURN_NONE;
@@ -959,7 +959,7 @@
     int rv;
 
     assert (i >= 0 && i < Py_SIZE(deque));
-    if (_deque_rotate(deque, -i) == -1)
+    if (_deque_rotate(deque, -i))
         return -1;
     item = deque_popleft(deque, NULL);
     rv = _deque_rotate(deque, i);