bpo-41943: Fix bug where assertLogs doesn't correctly filter messages… (GH-22565)
… by level
@vsajip , @pitrou
Automerge-Triggered-By: GH:vsajip
diff --git a/Lib/unittest/_log.py b/Lib/unittest/_log.py
index 961c448..94868e5 100644
--- a/Lib/unittest/_log.py
+++ b/Lib/unittest/_log.py
@@ -47,6 +47,7 @@ def __enter__(self):
logger = self.logger = logging.getLogger(self.logger_name)
formatter = logging.Formatter(self.LOGGING_FORMAT)
handler = _CapturingHandler()
+ handler.setLevel(self.level)
handler.setFormatter(formatter)
self.watcher = handler.watcher
self.old_handlers = logger.handlers[:]
diff --git a/Lib/unittest/test/test_case.py b/Lib/unittest/test/test_case.py
index 0e41696..b8aca92 100644
--- a/Lib/unittest/test/test_case.py
+++ b/Lib/unittest/test/test_case.py
@@ -1673,6 +1673,18 @@ def testAssertLogsFailureLevelTooHigh(self):
with self.assertLogs(level='WARNING'):
log_foo.info("1")
+ def testAssertLogsFailureLevelTooHigh_FilterInRootLogger(self):
+ # Failure due to level too high - message propagated to root
+ with self.assertNoStderr():
+ oldLevel = log_foo.level
+ log_foo.setLevel(logging.INFO)
+ try:
+ with self.assertRaises(self.failureException):
+ with self.assertLogs(level='WARNING'):
+ log_foo.info("1")
+ finally:
+ log_foo.setLevel(oldLevel)
+
def testAssertLogsFailureMismatchingLogger(self):
# Failure due to mismatching logger (and the logged message is
# passed through)