tree 6d5f9d2f8bd86dbd219685a3e6124af44a158811
parent 410759fba80aded5247b693c60745aa16906f3bb
author Mark Dickinson <dickinsm@gmail.com> 1558178990 +0100
committer GitHub <noreply@github.com> 1558178990 +0100
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJc3+yuCRBK7hj4Ov3rIwAAdHIIAJX0X16emV5hWpsx34jS+MrM
 a3hvihlQcbbvguC4re6V1STuLTXQZzW+wvw5yduTArboSWrb5dnwSK1B3XdveMm9
 JPuEGMQK4IvrxOJq5JwG/uSfNDkHEjEi6Jj2IpTI8qWOy4FfNSlLNJk0CH4X6L+v
 RymutPPahd+2Y+NGrF7UbTnQ+Paulx+VQTwh1mRMZaxhLehxxEZ1iwmjlcgvxAax
 DBBrHa3kCay/Thap0FigPPMzl9EgwK6dccep3CRe1xk0nE8O/q+P2FusYh76NaS2
 DnzsBGFK3TD7DsjIncJlgxv6OSm9+RmWzUj3zuD5aJODQEodPog1trEzWylh8no=
 =blf2
 -----END PGP SIGNATURE-----
 

bpo-36887: add math.isqrt (GH-13244)

* Add math.isqrt function computing the integer square root.

* Code cleanup: remove redundant comments, rename some variables.

* Tighten up code a bit more; use Py_XDECREF to simplify error handling.

* Update Modules/mathmodule.c

Co-Authored-By: Serhiy Storchaka <storchaka@gmail.com>

* Update Modules/mathmodule.c

Use real argument clinic type instead of an alias

Co-Authored-By: Serhiy Storchaka <storchaka@gmail.com>

* Add proof sketch

* Updates from review.

* Correct and expand documentation.

* Fix bad reference handling on error; make some variables block-local; other tidying.

* Style and consistency fixes.

* Add missing error check; don't try to DECREF a NULL a

* Simplify some error returns.

* Another two test cases:

- clarify that floats are rejected even if they happen to be
  squares of small integers
- TypeError beats ValueError for a negative float

* Documentation and markup improvements; thanks Serhiy for the suggestions!

* Cleaner Misc/NEWS entry wording.

* Clean up (with one fix) to the algorithm explanation and proof.