commit 758ad54dac6360657173d1c56f60510e5cdd08b6
author Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> Fri Sep 28 23:01:48 2018 -0700
committer GitHub <noreply@github.com> Fri Sep 28 23:01:48 2018 -0700
tree d2a6c429a6580ece6529de7ac4f2568a986db32d
parent 007fda436f707ac95c2fa8f8886efd9e09d5b630

Fix incorrect error handling in _pickle.Unpickler.__init__() (GH-9630)


_pickle.Unpickler.__init__() should return -1 if Pdata_New() fails, not 1.
(cherry picked from commit 4b430e5f6954ef4b248e95bfb4087635dcdefc6d)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>

Modules/_pickle.c

diff --git a/Modules/_pickle.c b/Modules/_pickle.c
index 34ce38c..ba8962d 100644
--- a/Modules/_pickle.c
+++ b/Modules/_pickle.c
@@ -6804,7 +6804,7 @@
 
     self->stack = (Pdata *)Pdata_New();
     if (self->stack == NULL)
-        return 1;
+        return -1;
 
     self->memo_size = 32;
     self->memo = _Unpickler_NewMemo(self->memo_size);