bpo-28518: Start a transaction implicitly before a DML statement (#245) (#318)
Patch by Aviv Palivoda.
(cherry picked from commit 4a926caf8e5fd8af771b2c34bfb6e91c732331fe)
diff --git a/Modules/_sqlite/statement.c b/Modules/_sqlite/statement.c
index 0df661b..087375b 100644
--- a/Modules/_sqlite/statement.c
+++ b/Modules/_sqlite/statement.c
@@ -73,8 +73,9 @@
Py_INCREF(sql);
self->sql = sql;
- /* determine if the statement is a DDL statement */
- self->is_ddl = 0;
+ /* Determine if the statement is a DML statement.
+ SELECT is the only exception. See #9924. */
+ self->is_dml = 0;
for (p = sql_cstr; *p != 0; p++) {
switch (*p) {
case ' ':
@@ -84,9 +85,10 @@
continue;
}
- self->is_ddl = (PyOS_strnicmp(p, "create ", 7) == 0)
- || (PyOS_strnicmp(p, "drop ", 5) == 0)
- || (PyOS_strnicmp(p, "reindex ", 8) == 0);
+ self->is_dml = (PyOS_strnicmp(p, "insert ", 7) == 0)
+ || (PyOS_strnicmp(p, "update ", 7) == 0)
+ || (PyOS_strnicmp(p, "delete ", 7) == 0)
+ || (PyOS_strnicmp(p, "replace ", 8) == 0);
break;
}