commit 7705d0aaafb6b034e9a3582e57f77d8f9cb5aa91
author Kristján Valur Jónsson <kristjan@ccpgames.com> Tue Mar 03 03:20:42 2009 +0000
committer Kristján Valur Jónsson <kristjan@ccpgames.com> Tue Mar 03 03:20:42 2009 +0000
tree 3e75fadc1393ecf69f39ef7f032bd99127d6b065
parent 7d49bba969a6ca490ade6aa908e350d3c05f76f4

Fix SHA_new and MD5_new, that would crash if not given initial data

Modules/md5module.c

diff --git a/Modules/md5module.c b/Modules/md5module.c
index 0b150a0..7081706 100644
--- a/Modules/md5module.c
+++ b/Modules/md5module.c
@@ -272,19 +272,21 @@
 	if (!PyArg_ParseTuple(args, "|O:new", &data_obj))
 		return NULL;
 
-	GET_BUFFER_VIEW_OR_ERROUT(data_obj, &view, NULL);
+	if (data_obj)
+		GET_BUFFER_VIEW_OR_ERROUT(data_obj, &view, NULL);
 
 	if ((md5p = newmd5object()) == NULL) {
-		PyBuffer_Release(&view);
+		if (data_obj)
+			PyBuffer_Release(&view);
 		return NULL;
 	}
 
 	if (data_obj) {
 		md5_append(&md5p->md5, (unsigned char*)view.buf,
 		       Py_SAFE_DOWNCAST(view.len, Py_ssize_t, unsigned int));
+		PyBuffer_Release(&view);
 	}
-
-	PyBuffer_Release(&view);
+	
 	return (PyObject *)md5p;
 }
 

Modules/shamodule.c

diff --git a/Modules/shamodule.c b/Modules/shamodule.c
index e89a1ea..6399b75 100644
--- a/Modules/shamodule.c
+++ b/Modules/shamodule.c
@@ -548,10 +548,12 @@
         return NULL;
     }
 
-    GET_BUFFER_VIEW_OR_ERROUT(data_obj, &view, NULL);
+    if (data_obj)
+        GET_BUFFER_VIEW_OR_ERROUT(data_obj, &view, NULL);
 
     if ((new = newSHAobject()) == NULL) {
-        PyBuffer_Release(&view);
+        if (data_obj)
+            PyBuffer_Release(&view);
         return NULL;
     }
 
@@ -559,15 +561,16 @@
 
     if (PyErr_Occurred()) {
         Py_DECREF(new);
-        PyBuffer_Release(&view);
+        if (data_obj)
+            PyBuffer_Release(&view);
         return NULL;
     }
     if (data_obj) {
         sha_update(new, (unsigned char*)view.buf,
                    Py_SAFE_DOWNCAST(view.len, Py_ssize_t, unsigned int));
+        PyBuffer_Release(&view);
     }
 
-    PyBuffer_Release(&view);
     return (PyObject *)new;
 }