commit 78162daff670696e64d570ed070fbda33b25890d
author Georg Brandl <georg@python.org> Sat Feb 14 17:04:26 2009 +0000
committer Georg Brandl <georg@python.org> Sat Feb 14 17:04:26 2009 +0000
tree 13094b4e1914fd672442e9197eac2f65e0a1d4c5
parent 02bdf93b85e168f2b9015f1a59fc2487acba0e01

Merged revisions 69620 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/trunk

........
  r69620 | georg.brandl | 2009-02-14 18:01:36 +0100 (Sa, 14 Feb 2009) | 1 line

  #5179: don't leak PIPE fds when child execution fails.
........

Lib/subprocess.py

diff --git a/Lib/subprocess.py b/Lib/subprocess.py
index 935827a..29a3d59 100644
--- a/Lib/subprocess.py
+++ b/Lib/subprocess.py
@@ -1103,6 +1103,9 @@
             if data != "":
                 os.waitpid(self.pid, 0)
                 child_exception = pickle.loads(data)
+                for fd in (p2cwrite, c2pread, errread):
+                    if fd is not None:
+                        os.close(fd)
                 raise child_exception