Fix two potential uninitialization errors and an unneeded assignment.
Found using Clang's static analyzer.
diff --git a/Modules/bsddbmodule.c b/Modules/bsddbmodule.c
index 0972882..c55df11 100644
--- a/Modules/bsddbmodule.c
+++ b/Modules/bsddbmodule.c
@@ -270,11 +270,12 @@
{
int status;
DBT krec, drec;
- char *data,buf[4096];
+ char *data = NULL;
+ char buf[4096];
int size;
PyObject *result;
recno_t recno;
-
+
if (dp->di_type == DB_RECNO) {
if (!PyArg_Parse(key, "i", &recno)) {
PyErr_SetString(PyExc_TypeError,
@@ -503,7 +504,8 @@
{
int status;
DBT krec, drec;
- char *data,buf[4096];
+ char *data = NULL;
+ char buf[4096];
int size;
PyObject *result;
recno_t recno;
@@ -635,7 +637,7 @@
PyErr_SetFromErrno(BsddbError);
return NULL;
}
- return PyInt_FromLong(status = 0);
+ return PyInt_FromLong(0);
}
static PyMethodDef bsddb_methods[] = {
{"close", (PyCFunction)bsddb_close, METH_NOARGS},