commit 7cd581a6bf82309b3c9b9251c54067d442732485
author Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> Thu Jun 13 23:13:24 2019 -0700
committer GitHub <noreply@github.com> Thu Jun 13 23:13:24 2019 -0700
tree caf61efc5b45cc164db9d301d600216a63b87df0
parent 886d83e5aa8df2dd2e93421d2f614438a3244a1c

bpo-37269: Correctly optimise conditionals with constant booleans (GH-14071)


Fix a regression introduced by af8646c8054d0f4180a2013383039b6a472f9698 that was causing code of the form:

if True and False:
   do_something()

to be optimized incorrectly, eliminating the block.
(cherry picked from commit 05f831865545b08c9a21cfb7773af58b76ec64cb)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>

Lib/test/test_peepholer.py

diff --git a/Lib/test/test_peepholer.py b/Lib/test/test_peepholer.py
index 860ceeb..5d00240 100644
--- a/Lib/test/test_peepholer.py
+++ b/Lib/test/test_peepholer.py
@@ -414,6 +414,13 @@
                 pass
         self.assertEqual(count_instr_recursively(forloop, 'BUILD_LIST'), 0)
 
+    def test_condition_with_binop_with_bools(self):
+        def f():
+            if True or False:
+                return 1
+            return 0
+        self.assertEqual(f(), 1)
+
 
 class TestBuglets(unittest.TestCase):