commit 8404749e4b65f23a7d84c3940ea061eee0b4b344
author Hirokazu Yamamoto <ocean-city@m2.ccsnet.ne.jp> Tue Mar 03 07:49:01 2009 +0000
committer Hirokazu Yamamoto <ocean-city@m2.ccsnet.ne.jp> Tue Mar 03 07:49:01 2009 +0000
tree d8082d486912a2af4485d4b47dceee81bc6a3f02
parent 45ed72ddaf16c97237f2ad522959d6ffd8b40e2e

Fixed memory leak on failure. This is related to issue5403 but won't crash on py3k.

Modules/sha256module.c

diff --git a/Modules/sha256module.c b/Modules/sha256module.c
index c653416..7c9b58d 100644
--- a/Modules/sha256module.c
+++ b/Modules/sha256module.c
@@ -629,13 +629,18 @@
     if (data_obj)
         GET_BUFFER_VIEW_OR_ERROUT(data_obj, &buf);
 
-    if ((new = newSHA256object()) == NULL)
+    if ((new = newSHA256object()) == NULL) {
+        if (data_obj)
+            PyBuffer_Release(&buf);
         return NULL;
+    }
 
     sha_init(new);
 
     if (PyErr_Occurred()) {
         Py_DECREF(new);
+        if (data_obj)
+            PyBuffer_Release(&buf);
         return NULL;
     }
     if (data_obj) {
@@ -665,13 +670,18 @@
     if (data_obj)
         GET_BUFFER_VIEW_OR_ERROUT(data_obj, &buf);
 
-    if ((new = newSHA224object()) == NULL)
+    if ((new = newSHA224object()) == NULL) {
+        if (data_obj)
+            PyBuffer_Release(&buf);
         return NULL;
+    }
 
     sha224_init(new);
 
     if (PyErr_Occurred()) {
         Py_DECREF(new);
+        if (data_obj)
+            PyBuffer_Release(&buf);
         return NULL;
     }
     if (data_obj) {