commit 88ad48bc98980a40591cc5521703dbb0ad3a9b17
author Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> Tue Jan 08 05:40:50 2019 -0800
committer GitHub <noreply@github.com> Tue Jan 08 05:40:50 2019 -0800
tree 3e2b6667268fc0091cfc573f8586d6b0b80cfd5f
parent 69f64b67e43c65c2178c865fd1be80ed07f02d3c

bpo-32710: Fix leak in Overlapped_WSASend() (GH-11469)


Fix a memory leak in asyncio in the ProactorEventLoop when ReadFile()
or WSASend() overlapped operation fail immediately: release the
internal buffer.
(cherry picked from commit a234e148394c2c7419372ab65b773d53a57f3625)

Co-authored-by: Victor Stinner <vstinner@redhat.com>

Modules/overlapped.c

diff --git a/Modules/overlapped.c b/Modules/overlapped.c
index ae7cdda..4ef5a96 100644
--- a/Modules/overlapped.c
+++ b/Modules/overlapped.c
@@ -723,6 +723,7 @@
         case ERROR_IO_PENDING:
             Py_RETURN_NONE;
         default:
+            PyBuffer_Release(&self->user_buffer);
             self->type = TYPE_NOT_STARTED;
             return SetFromWindowsErr(err);
     }
@@ -1011,6 +1012,7 @@
         case ERROR_IO_PENDING:
             Py_RETURN_NONE;
         default:
+            PyBuffer_Release(&self->user_buffer);
             self->type = TYPE_NOT_STARTED;
             return SetFromWindowsErr(err);
     }