commit 8905fcc85a6fc3ac394bc89b0bbf40897e9497a6
author Serhiy Storchaka <storchaka@gmail.com> Tue Dec 11 08:38:03 2018 +0200
committer GitHub <noreply@github.com> Tue Dec 11 08:38:03 2018 +0200
tree 5b7afcdceab6dae37e3db90f952c5c76fe46b5cf
parent bb86bf4c4eaa30b1f5192dab9f389ce0bb61114d

bpo-35454: Fix miscellaneous minor issues in error handling. (#11077)

* bpo-35454: Fix miscellaneous minor issues in error handling.

* Fix a null pointer dereference.

Modules/_elementtree.c

diff --git a/Modules/_elementtree.c b/Modules/_elementtree.c
index 62374d8..12e418d 100644
--- a/Modules/_elementtree.c
+++ b/Modules/_elementtree.c
@@ -352,7 +352,10 @@
             return NULL;
         }
         attrib = PyDict_Copy(attrib);
-        PyDict_DelItem(kwds, attrib_str);
+        if (attrib && PyDict_DelItem(kwds, attrib_str) < 0) {
+            Py_DECREF(attrib);
+            attrib = NULL;
+        }
     } else {
         attrib = PyDict_New();
     }