commit 8ae468965700fd9900efc28bff8fa2015dae2bef
author Raymond Hettinger <python@rcn.com> Sun Oct 12 19:09:37 2003 +0000
committer Raymond Hettinger <python@rcn.com> Sun Oct 12 19:09:37 2003 +0000
tree 1f3545b2d2a3ad8b7d5692a7f84daa88d850b29c
parent cb2da43db8943e9e7b1d900bce1d6416339d6f64

Simplify and speedup uses of Py_BuildValue():

* Py_BuildValue("(OOO)",a,b,c)  -->  PyTuple_Pack(3,a,b,c)
* Py_BuildValue("()",a)         -->  PyTuple_New(0)
* Py_BuildValue("O", a)         -->  Py_INCREF(a)

Modules/cStringIO.c

diff --git a/Modules/cStringIO.c b/Modules/cStringIO.c
index ac84ab0..ee11878 100644
--- a/Modules/cStringIO.c
+++ b/Modules/cStringIO.c
@@ -439,7 +439,7 @@
         tmp = PyObject_CallFunction(joiner, "O", args);
         UNLESS (tmp) return NULL;
 
-        args = Py_BuildValue("(O)", tmp);
+        args = PyTuple_Pack(1, tmp);
         Py_DECREF(tmp);
         UNLESS (args) return NULL;