commit 8debfa50407107ff2329d01081cdc12d359f1d12
author Serhiy Storchaka <storchaka@gmail.com> Mon Sep 16 20:15:18 2019 +0300
committer GitHub <noreply@github.com> Mon Sep 16 20:15:18 2019 +0300
tree 37668c95d2aad9ac11e6c9a97a2b0cccce3526b8
parent a9187c31185fe7ea47271839898416400cc3d976

bpo-38175: Fix a memory leak in comparison of sqlite3.Row objects. (GH-16155)

Modules/_sqlite/row.c

diff --git a/Modules/_sqlite/row.c b/Modules/_sqlite/row.c
index 5c2f400..758518a 100644
--- a/Modules/_sqlite/row.c
+++ b/Modules/_sqlite/row.c
@@ -192,14 +192,16 @@
     if (opid != Py_EQ && opid != Py_NE)
         Py_RETURN_NOTIMPLEMENTED;
 
-    if (PyType_IsSubtype(Py_TYPE(_other), &pysqlite_RowType)) {
+    if (PyObject_TypeCheck(_other, &pysqlite_RowType)) {
         pysqlite_Row *other = (pysqlite_Row *)_other;
-        PyObject *res = PyObject_RichCompare(self->description, other->description, opid);
-        if ((opid == Py_EQ && res == Py_True)
-            || (opid == Py_NE && res == Py_False)) {
-            Py_DECREF(res);
+        int eq = PyObject_RichCompareBool(self->description, other->description, Py_EQ);
+        if (eq < 0) {
+            return NULL;
+        }
+        if (eq) {
             return PyObject_RichCompare(self->data, other->data, opid);
         }
+        return PyBool_FromLong(opid != Py_EQ);
     }
     Py_RETURN_NOTIMPLEMENTED;
 }