bpo-30378: Fix the problem that SysLogHandler can't handle IPv6 addresses (#1676) (#1903)
diff --git a/Lib/test/test_logging.py b/Lib/test/test_logging.py
index 0a2584c..474affd 100644
--- a/Lib/test/test_logging.py
+++ b/Lib/test/test_logging.py
@@ -1663,7 +1663,7 @@
server.ready.wait()
hcls = logging.handlers.SysLogHandler
if isinstance(server.server_address, tuple):
- self.sl_hdlr = hcls(('localhost', server.port))
+ self.sl_hdlr = hcls((server.server_address[0], server.port))
else:
self.sl_hdlr = hcls(server.server_address)
self.log_output = ''
@@ -1723,6 +1723,24 @@
SysLogHandlerTest.tearDown(self)
support.unlink(self.address)
+@unittest.skipUnless(support.IPV6_ENABLED,
+ 'IPv6 support required for this test.')
+@unittest.skipUnless(threading, 'Threading required for this test.')
+class IPv6SysLogHandlerTest(SysLogHandlerTest):
+
+ """Test for SysLogHandler with IPv6 host."""
+
+ server_class = TestUDPServer
+ address = ('::1', 0)
+
+ def setUp(self):
+ self.server_class.address_family = socket.AF_INET6
+ super(IPv6SysLogHandlerTest, self).setUp()
+
+ def tearDown(self):
+ self.server_class.address_family = socket.AF_INET
+ super(IPv6SysLogHandlerTest, self).tearDown()
+
@unittest.skipUnless(threading, 'Threading required for this test.')
class HTTPHandlerTest(BaseTest):
"""Test for HTTPHandler."""
@@ -4378,7 +4396,7 @@
QueueHandlerTest, ShutdownTest, ModuleLevelMiscTest, BasicConfigTest,
LoggerAdapterTest, LoggerTest, SMTPHandlerTest, FileHandlerTest,
RotatingFileHandlerTest, LastResortTest, LogRecordTest,
- ExceptionTest, SysLogHandlerTest, HTTPHandlerTest,
+ ExceptionTest, SysLogHandlerTest, IPv6SysLogHandlerTest, HTTPHandlerTest,
NTEventLogHandlerTest, TimedRotatingFileHandlerTest,
UnixSocketHandlerTest, UnixDatagramHandlerTest, UnixSysLogHandlerTest,
MiscTestCase