merge with 3.2
diff --git a/Lib/aifc.py b/Lib/aifc.py
index 4646285..7774325 100644
--- a/Lib/aifc.py
+++ b/Lib/aifc.py
@@ -539,8 +539,7 @@
self._aifc = 1 # AIFF-C is default
def __del__(self):
- if self._file:
- self.close()
+ self.close()
#
# User visible methods.
@@ -643,8 +642,8 @@
raise Error('marker ID must be > 0')
if pos < 0:
raise Error('marker position must be >= 0')
- if not isinstance(name, str):
- raise Error('marker name must be a string')
+ if not isinstance(name, bytes):
+ raise Error('marker name must be bytes')
for i in range(len(self._markers)):
if id == self._markers[i][0]:
self._markers[i] = id, pos, name
@@ -681,19 +680,21 @@
self._patchheader()
def close(self):
- self._ensure_header_written(0)
- if self._datawritten & 1:
- # quick pad to even size
- self._file.write(b'\x00')
- self._datawritten = self._datawritten + 1
- self._writemarkers()
- if self._nframeswritten != self._nframes or \
- self._datalength != self._datawritten or \
- self._marklength:
- self._patchheader()
- # Prevent ref cycles
- self._convert = None
- self._file.close()
+ if self._file:
+ self._ensure_header_written(0)
+ if self._datawritten & 1:
+ # quick pad to even size
+ self._file.write(b'\x00')
+ self._datawritten = self._datawritten + 1
+ self._writemarkers()
+ if self._nframeswritten != self._nframes or \
+ self._datalength != self._datawritten or \
+ self._marklength:
+ self._patchheader()
+ # Prevent ref cycles
+ self._convert = None
+ self._file.close()
+ self._file = None
#
# Internal methods.
diff --git a/Lib/test/test_aifc.py b/Lib/test/test_aifc.py
index af2305f..085b949 100644
--- a/Lib/test/test_aifc.py
+++ b/Lib/test/test_aifc.py
@@ -120,6 +120,29 @@
self.assertEqual(fout.getsampwidth(), 2)
fout.initfp(None)
+ def test_write_markers_values(self):
+ fout = self.fout = aifc.open(io.BytesIO(), 'wb')
+ self.assertEqual(fout.getmarkers(), None)
+ fout.setmark(1, 0, b'foo1')
+ fout.setmark(1, 1, b'foo2')
+ self.assertEqual(fout.getmark(1), (1, 1, b'foo2'))
+ self.assertEqual(fout.getmarkers(), [(1, 1, b'foo2')])
+ fout.initfp(None)
+
+ def test_read_markers(self):
+ fout = self.fout = aifc.open(TESTFN, 'wb')
+ fout.aiff()
+ fout.setparams((1, 1, 1, 1, b'NONE', b''))
+ fout.setmark(1, 0, b'odd')
+ fout.setmark(2, 0, b'even')
+ fout.writeframes(b'\x00')
+ fout.close()
+ f = self.f = aifc.open(TESTFN, 'rb')
+ self.assertEqual(f.getmarkers(), [(1, 0, b'odd'), (2, 0, b'even')])
+ self.assertEqual(f.getmark(1), (1, 0, b'odd'))
+ self.assertEqual(f.getmark(2), (2, 0, b'even'))
+ self.assertRaises(aifc.Error, f.getmark, 3)
+
def test_main():
run_unittest(AIFCTest)