commit 9932fd91e878b740704ff599522e945a4bbe2ae1
author Niklas Fiekas <niklas.fiekas@backscattering.de> Mon May 20 14:02:17 2019 +0200
committer Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> Mon May 20 05:02:16 2019 -0700
tree 2aa24d867fc52f03e9312cd8617a12263f84c150
parent 6d1c46746e17367caf8a24623cb5c9a9c4e3e036

bpo-35721: Close socket pair if Popen in _UnixSubprocessTransport fails (GH-11553)



This slightly expands an existing test case `test_popen_error` to trigger a `ResourceWarning` and fixes it.


https://bugs.python.org/issue35721

Misc/ACKS

diff --git a/Misc/ACKS b/Misc/ACKS
index 8b32325..77f1990 100644
--- a/Misc/ACKS
+++ b/Misc/ACKS
@@ -486,6 +486,7 @@
 John Feuerstein
 Carl Feynman
 Vincent Fiack
+Niklas Fiekas
 Anastasia Filatova
 Tomer Filiba
 Segev Finer

Misc/NEWS.d/next/Library/2019-01-18-16-23-00.bpo-35721.d8djAJ.rst

diff --git a/Misc/NEWS.d/next/Library/2019-01-18-16-23-00.bpo-35721.d8djAJ.rst b/Misc/NEWS.d/next/Library/2019-01-18-16-23-00.bpo-35721.d8djAJ.rst
new file mode 100644
index 0000000..5af4b1b
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2019-01-18-16-23-00.bpo-35721.d8djAJ.rst
@@ -0,0 +1,3 @@
+Fix :meth:`asyncio.SelectorEventLoop.subprocess_exec()` leaks file descriptors
+if ``Popen`` fails and called with ``stdin=subprocess.PIPE``.
+Patch by Niklas Fiekas.