tree e7070f68ca2a98d0dcbb9e285c23287752b7951a
parent 61acf067ac7820d5e5a02c17d3d55f7f19a8e52e
author Jeremy Hylton <jeremy@alum.mit.edu> 1003273352 +0000
committer Jeremy Hylton <jeremy@alum.mit.edu> 1003273352 +0000
HG:extra convert_revision:svn%3A6015fed2-1504-0410-9fe1-9d1591cc4771/python/branches/legacy-trunk%4023741

Simplify and fix error handling for most cases.

Many functions used a local variable called return_error, which was
initialized to zero.  If an error occurred, it was set to true.  Most
of the code paths checked were only executed if return_error was
false.  goto is clearer.

The code also seemed to be written under the curious assumption that
calling Py_DECREF() on a local variable would assign the variable to
NULL.  As a result, more of the error-exit code paths returned an
object that had a reference count of zero instead of just returning
NULL.  Fixed the code to explicitly assign NULL after the DECREF.

A bit more reformatting, but not much.

XXX Need a much better test suite for zlib, since it the current tests
don't exercise any of this broken code.