bpo-35942: Improve the error message if __fspath__ returns invalid types in path_converter (GH-11831)
The error message emitted when returning invalid types from __fspath__ in interfaces that allow passing PathLike objects has been improved and now it does explain the origin of the error.
(cherry picked from commit 09fbcd6085e18b534fd4161844ff39f77eb4a082)
Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
diff --git a/Lib/test/test_os.py b/Lib/test/test_os.py
index ff22fbe..0614471 100644
--- a/Lib/test/test_os.py
+++ b/Lib/test/test_os.py
@@ -3297,7 +3297,7 @@
cleanup_fn(result)
with self.assertRaisesRegex(
- TypeError, 'should be string, bytes'):
+ TypeError, 'to return str or bytes'):
fn(int_fspath, *extra_args)
if allow_fd:
@@ -3310,6 +3310,23 @@
'os.PathLike'):
fn(fd, *extra_args)
+ def test_path_t_converter_and_custom_class(self):
+ with self.assertRaisesRegex(
+ TypeError,
+ '__fspath__\(\) to return str or bytes, not int'
+ ):
+ os.stat(FakePath(2))
+ with self.assertRaisesRegex(
+ TypeError,
+ '__fspath__\(\) to return str or bytes, not float'
+ ):
+ os.stat(FakePath(2.34))
+ with self.assertRaisesRegex(
+ TypeError,
+ '__fspath__\(\) to return str or bytes, not object'
+ ):
+ os.stat(FakePath(object()))
+
@unittest.skipUnless(hasattr(os, 'get_blocking'),
'needs os.get_blocking() and os.set_blocking()')