commit a6563650c835d50f7302971a5b145e94f9d0dc68
author Zackery Spytz <zspytz@gmail.com> Mon Sep 09 03:20:39 2019 -0600
committer Steve Dower <steve.dower@python.org> Mon Sep 09 02:20:38 2019 -0700
tree 9633cf07c93d183f095a39314b55e59d26b68bcd
parent 7669cb8b21c7c9cef758609c44017c09d1ce4658

bpo-37445: Include FORMAT_MESSAGE_IGNORE_INSERTS in FormatMessageW() calls (GH-14462)

If FormatMessageW() is passed the FORMAT_MESSAGE_FROM_SYSTEM flag without FORMAT_MESSAGE_IGNORE_INSERTS, it will fail if there are insert sequences in the message definition.

PC/bdist_wininst/install.c

diff --git a/PC/bdist_wininst/install.c b/PC/bdist_wininst/install.c
index 0219a19..5d77542 100644
--- a/PC/bdist_wininst/install.c
+++ b/PC/bdist_wininst/install.c
@@ -938,7 +938,8 @@
         LPVOID lpMsgBuf;
         FormatMessage(
             FORMAT_MESSAGE_ALLOCATE_BUFFER |
-            FORMAT_MESSAGE_FROM_SYSTEM,
+            FORMAT_MESSAGE_FROM_SYSTEM |
+            FORMAT_MESSAGE_IGNORE_INSERTS,
             NULL,
             error,
             MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT),