commit a7874c73c0c729bbec2fd4b077bd0eec276cfff4
author Eric N. Vander Weele <ericvw@gmail.com> Mon Jun 26 21:35:20 2017 -0400
committer Victor Stinner <victor.stinner@gmail.com> Tue Jun 27 03:35:20 2017 +0200
tree 10f4bd8853b79faf44e3bf2d0847dabff973d8f3
parent 48b5c422ffb03affb00c184b9a99e5537be92732

bpo-30769: Fix reference leak introduced in 77703942c59 (#2416)

New error condition paths were introduced, which did not decrement
`key2` and `val2` objects.  Therefore, decrement references before
jumping to the error label.

Signed-off-by: Eric N. Vander Weele <ericvw@gmail.com>

Misc/ACKS

diff --git a/Misc/ACKS b/Misc/ACKS
index 89cd1fa..a6d1e0f 100644
--- a/Misc/ACKS
+++ b/Misc/ACKS
@@ -1611,6 +1611,7 @@
 Case Van Horsen
 John Mark Vandenberg
 Kyle VanderBeek
+Eric N. Vander Weele
 Andrew Vant
 Atul Varma
 Dmitry Vasiliev

Modules/posixmodule.c

diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c
index 79efb4c..1c75eae 100644
--- a/Modules/posixmodule.c
+++ b/Modules/posixmodule.c
@@ -4900,6 +4900,8 @@
             PyUnicode_FindChar(key2, '=', 1, PyUnicode_GET_LENGTH(key2), 1) != -1)
         {
             PyErr_SetString(PyExc_ValueError, "illegal environment variable name");
+            Py_DECREF(key2);
+            Py_DECREF(val2);
             goto error;
         }
         keyval = PyUnicode_FromFormat("%U=%U", key2, val2);
@@ -4914,6 +4916,8 @@
             strchr(PyBytes_AS_STRING(key2) + 1, '=') != NULL)
         {
             PyErr_SetString(PyExc_ValueError, "illegal environment variable name");
+            Py_DECREF(key2);
+            Py_DECREF(val2);
             goto error;
         }
         keyval = PyBytes_FromFormat("%s=%s", PyBytes_AS_STRING(key2),