bpo-26133: Fix typos (#5010)
* Fix typos
* Change warning text
* Add test
diff --git a/Lib/asyncio/unix_events.py b/Lib/asyncio/unix_events.py
index 5d6a3c0..4f6beb4 100644
--- a/Lib/asyncio/unix_events.py
+++ b/Lib/asyncio/unix_events.py
@@ -56,9 +56,9 @@
self.remove_signal_handler(sig)
else:
if self._signal_handlers:
- warinigs.warn(f"Closing the loop {self!r} "
+ warnings.warn(f"Closing the loop {self!r} "
f"on interpreter shutdown "
- f"stage, signal unsubsription is disabled",
+ f"stage, skipping signal handlers removal",
ResourceWarning,
source=self)
self._signal_handlers.clear()
diff --git a/Lib/test/test_asyncio/test_unix_events.py b/Lib/test/test_asyncio/test_unix_events.py
index 097d0ef7..53ed3d9 100644
--- a/Lib/test/test_asyncio/test_unix_events.py
+++ b/Lib/test/test_asyncio/test_unix_events.py
@@ -229,6 +229,23 @@
self.assertEqual(len(self.loop._signal_handlers), 0)
m_signal.set_wakeup_fd.assert_called_once_with(-1)
+ @mock.patch('asyncio.unix_events.sys')
+ @mock.patch('asyncio.unix_events.signal')
+ def test_close_on_finalizing(self, m_signal, m_sys):
+ m_signal.NSIG = signal.NSIG
+ self.loop.add_signal_handler(signal.SIGHUP, lambda: True)
+
+ self.assertEqual(len(self.loop._signal_handlers), 1)
+ m_sys.is_finalizing.return_value = True
+ m_signal.signal.reset_mock()
+
+ with self.assertWarnsRegex(ResourceWarning,
+ "skipping signal handlers removal"):
+ self.loop.close()
+
+ self.assertEqual(len(self.loop._signal_handlers), 0)
+ self.assertFalse(m_signal.signal.called)
+
@unittest.skipUnless(hasattr(socket, 'AF_UNIX'),
'UNIX Sockets are not supported')