commit aa5bbfaa77a14634a035233a8879351d320bad6c
author Victor Stinner <victor.stinner@gmail.com> Fri Nov 08 00:29:41 2013 +0100
committer Victor Stinner <victor.stinner@gmail.com> Fri Nov 08 00:29:41 2013 +0100
tree b63057d9185eaa805656bf822e2c583f94254075
parent 50abf2294ed5623e9b8025c5ed8e143f2f4af75c

Issue #19437: Fix _io._IOBase.close(), handle _PyObject_SetAttrId() failure

Modules/_io/iobase.c

diff --git a/Modules/_io/iobase.c b/Modules/_io/iobase.c
index b58687e..3da7e5d 100644
--- a/Modules/_io/iobase.c
+++ b/Modules/_io/iobase.c
@@ -186,11 +186,16 @@
         Py_RETURN_NONE;
 
     res = PyObject_CallMethodObjArgs(self, _PyIO_str_flush, NULL);
-    _PyObject_SetAttrId(self, &PyId___IOBase_closed, Py_True);
-    if (res == NULL) {
+
+    if (_PyObject_SetAttrId(self, &PyId___IOBase_closed, Py_True) < 0) {
+        Py_XDECREF(res);
         return NULL;
     }
-    Py_XDECREF(res);
+
+    if (res == NULL)
+        return NULL;
+
+    Py_DECREF(res);
     Py_RETURN_NONE;
 }