Don't use a sleep to wait for the server to be ready; this caused
problems on my OSX laptop. use a condition variable instead.
diff --git a/Lib/test/test_poplib.py b/Lib/test/test_poplib.py
index 35ff636..ef8565c 100644
--- a/Lib/test/test_poplib.py
+++ b/Lib/test/test_poplib.py
@@ -7,12 +7,13 @@
from test import test_support
-def server(evt):
+def server(ready, evt):
serv = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
serv.settimeout(3)
serv.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1)
serv.bind(("", 9091))
serv.listen(5)
+ ready.set()
try:
conn, addr = serv.accept()
except socket.timeout:
@@ -28,8 +29,9 @@
def setUp(self):
self.evt = threading.Event()
- threading.Thread(target=server, args=(self.evt,)).start()
- time.sleep(.1)
+ self.ready = threading.Event()
+ threading.Thread(target=server, args=(self.ready, self.evt,)).start()
+ self.ready.wait()
def tearDown(self):
self.evt.wait()