commit b03142782c84c3ce6ba0a86a3af93c08b84f32e6
author Victor Stinner <victor.stinner@gmail.com> Thu Nov 14 21:37:05 2013 +0100
committer Victor Stinner <victor.stinner@gmail.com> Thu Nov 14 21:37:05 2013 +0100
tree 458973cf0a6584e84805d95adc44dca3bbfa01cf
parent b80b37868069fc5ff459f41565163c417fa3cf12

Issue #19437: Fix parse_envlist() of the posix/nt module, don't call
PyMapping_Values() with an exception set, exit immediatly on error.

Modules/posixmodule.c

diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c
index 5e5f355..7e6bdc8 100644
--- a/Modules/posixmodule.c
+++ b/Modules/posixmodule.c
@@ -5083,8 +5083,10 @@
     }
     envc = 0;
     keys = PyMapping_Keys(env);
+    if (!keys)
+        goto error;
     vals = PyMapping_Values(env);
-    if (!keys || !vals)
+    if (!vals)
         goto error;
     if (!PyList_Check(keys) || !PyList_Check(vals)) {
         PyErr_Format(PyExc_TypeError,