commit b5ea5e57f5dd23e1db695dda8bf3f6142ed9074f
author Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> Thu Nov 15 01:25:34 2018 -0800
committer GitHub <noreply@github.com> Thu Nov 15 01:25:34 2018 -0800
tree 01a6f27d4a483838d58271a2c1082749448b0201
parent b6b56b49e9d9b3e0e8b7bc24a6b1a55db6bc1da0

Fix a possible reference leak in _socket.getaddrinfo(). (GH-10543)


"single" needs to be decrefed if PyList_Append() fails.
(cherry picked from commit 4c596d54aa6a55e9d2a3db78891e656ebbfb63c8)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>

Modules/socketmodule.c

diff --git a/Modules/socketmodule.c b/Modules/socketmodule.c
index eeade2e..ddb1c43 100644
--- a/Modules/socketmodule.c
+++ b/Modules/socketmodule.c
@@ -6269,9 +6269,11 @@
         if (single == NULL)
             goto err;
 
-        if (PyList_Append(all, single))
+        if (PyList_Append(all, single)) {
+            Py_DECREF(single);
             goto err;
-        Py_XDECREF(single);
+        }
+        Py_DECREF(single);
     }
     Py_XDECREF(idna);
     if (res0)