commit b803c6c4b8d6256ac3d69f07f28c5c7024c3d4f5
author Gregory P. Smith <greg@krypto.org> Sat Mar 23 16:05:36 2013 -0700
committer Gregory P. Smith <greg@krypto.org> Sat Mar 23 16:05:36 2013 -0700
tree 8758eaf66c77333c75998de33053b5ce5384a0f5
parent 93f756b274fb376d4c7fe589b1211acb49cea092

Fixes issue4653 - Correctly specify the buffer size to FormatMessageW and
correctly check for errors on two CreateFileMapping calls.

PC/bdist_wininst/extract.c

diff --git a/PC/bdist_wininst/extract.c b/PC/bdist_wininst/extract.c
index c900f23..aec8eda 100644
--- a/PC/bdist_wininst/extract.c
+++ b/PC/bdist_wininst/extract.c
@@ -127,7 +127,7 @@
 
     CloseHandle(hFile);
 
-    if (hFileMapping == INVALID_HANDLE_VALUE) {
+    if (hFileMapping == NULL) {
         if (notify)
             notify(SYSTEM_ERROR,
                    "CreateFileMapping (%s)", filename);

PC/bdist_wininst/install.c

diff --git a/PC/bdist_wininst/install.c b/PC/bdist_wininst/install.c
index 771922c..c11d45d 100644
--- a/PC/bdist_wininst/install.c
+++ b/PC/bdist_wininst/install.c
@@ -1019,7 +1019,7 @@
                                       NULL, PAGE_READONLY, 0, 0, NULL);
     CloseHandle(hFile);
 
-    if (hFileMapping == INVALID_HANDLE_VALUE)
+    if (hFileMapping == NULL)
         return NULL;
 
     data = MapViewOfFile(hFileMapping,

Python/dynload_win.c

diff --git a/Python/dynload_win.c b/Python/dynload_win.c
index 25b6680..edb6038 100644
--- a/Python/dynload_win.c
+++ b/Python/dynload_win.c
@@ -235,7 +235,7 @@
                            SUBLANG_DEFAULT),
                            /* Default language */
                 theInfo, /* the buffer */
-                sizeof(theInfo), /* the buffer size */
+                sizeof(theInfo) / sizeof(wchar_t), /* size in wchars */
                 NULL); /* no additional format args. */
 
             /* Problem: could not get the error message.