commit bcbe5c59dde5fcb9ad21991c2afd91837b14bbd5
author Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> Thu May 28 08:12:23 2020 -0700
committer GitHub <noreply@github.com> Thu May 28 08:12:23 2020 -0700
tree 9952d8e5d30daad42d284486a79c89705d0a34e7
parent 1d82f003678816ff8dd822452ec91669844d2d09

bpo-40217:  Ensure Py_VISIT(Py_TYPE(self)) is always called for PyType_FromSpec types (reverts GH-19414) (GH-20264)


Heap types now always visit the type in tp_traverse. See added docs for details.

This reverts commit 0169d3003be3d072751dd14a5c84748ab63a249f.

Automerge-Triggered-By: @encukou
(cherry picked from commit 1cf15af9a6f28750f37b08c028ada31d38e818dd)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>

Objects/structseq.c

diff --git a/Objects/structseq.c b/Objects/structseq.c
index 9bdda87..b17b1f9 100644
--- a/Objects/structseq.c
+++ b/Objects/structseq.c
@@ -70,6 +70,9 @@
 static int
 structseq_traverse(PyStructSequence *obj, visitproc visit, void *arg)
 {
+    if (Py_TYPE(obj)->tp_flags & Py_TPFLAGS_HEAPTYPE) {
+        Py_VISIT(Py_TYPE(obj));
+    }
     Py_ssize_t i, size;
     size = REAL_SIZE(obj);
     for (i = 0; i < size; ++i) {