commit bea232a15fc818341217901772c7e622e9f9332d
author Victor Stinner <victor.stinner@gmail.com> Mon Jul 27 23:37:11 2015 +0200
committer Victor Stinner <victor.stinner@gmail.com> Mon Jul 27 23:37:11 2015 +0200
tree c53ef76ea843968d63c3bdf8563a4f731441cf57
parent 0659c43d73e5d9ce4540c53f76b66ddb904be6de

Issue #24732, #23834: Fix sock_accept_impl() on Windows

accept() returns INVALID_SOCKET on error, it's not necessary a negative number.

Modules/socketmodule.c

diff --git a/Modules/socketmodule.c b/Modules/socketmodule.c
index 7610b0c..ee24907 100644
--- a/Modules/socketmodule.c
+++ b/Modules/socketmodule.c
@@ -2211,7 +2211,12 @@
 #else
     ctx->result = accept(s->sock_fd, SAS2SA(ctx->addrbuf), ctx->addrlen);
 #endif
+
+#ifdef MS_WINDOWS
+    return (ctx->result != INVALID_SOCKET);
+#else
     return (ctx->result >= 0);
+#endif
 }
 
 /* s._accept() -> (fd, address) */