Merged revisions 69481 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/trunk
........
r69481 | brett.cannon | 2009-02-09 18:07:38 -0800 (Mon, 09 Feb 2009) | 4 lines
compileall used the ctime of bytecode and source to determine if the bytecode
should be recreated. This created a timing hole. Fixed by just doing what
import does; check the mtime and magic number.
........
diff --git a/Misc/ACKS b/Misc/ACKS
index 2af19b5..31f920e 100644
--- a/Misc/ACKS
+++ b/Misc/ACKS
@@ -183,7 +183,7 @@
Andy Dustman
Gary Duzan
Eugene Dvurechenski
-Josip Dzolonga
+Josip Dzolonga
Maxim Dzumanenko
Walter Dörwald
Hans Eckardt
@@ -234,6 +234,7 @@
Ulisses Furquim
Hagen Fürstenau
Achim Gaedke
+Martin von Gagern
Lele Gaifax
Santiago Gala
Yitzchak Gale
diff --git a/Misc/NEWS b/Misc/NEWS
index 515785c..aebbcde 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -163,6 +163,10 @@
Library
-------
+- Issue #5128: Make compileall properly inspect bytecode to determine if needs
+ to be recreated. This avoids a timing hole thanks to the old reliance on the
+ ctime of the files involved.
+
- Issue #5122: Synchronize tk load failure check to prevent a potential
deadlock.