commit c1964e9e2177eabe821f3e4243be8b99e0d2d542
author gescheit <gescheit12@gmail.com> Fri May 03 18:18:02 2019 +0300
committer Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> Fri May 03 08:18:02 2019 -0700
tree 7390706509d540575ca8d89c9d3c7d0973e20165
parent 4461d704e23a13dfbe78ea3020e4cbeff4b68dc2

bpo-36613: call remove_done_callback if exception (GH-12800)



Call remove_done_callback() in finally block.


https://bugs.python.org/issue36613

Lib/asyncio/tasks.py

diff --git a/Lib/asyncio/tasks.py b/Lib/asyncio/tasks.py
index d850837..007a459 100644
--- a/Lib/asyncio/tasks.py
+++ b/Lib/asyncio/tasks.py
@@ -495,10 +495,11 @@
     finally:
         if timeout_handle is not None:
             timeout_handle.cancel()
+        for f in fs:
+            f.remove_done_callback(_on_completion)
 
     done, pending = set(), set()
     for f in fs:
-        f.remove_done_callback(_on_completion)
         if f.done():
             done.add(f)
         else: