Fix problems found by Coverity.
longobject.c: also fix an ssize_t problem
<a> could have been NULL, so hoist the size calc to not use <a>.
_ssl.c: under fail: self is DECREF'd, but it would have been NULL.
_elementtree.c: delete self if there was an error.
_csv.c: I'm not sure if lineterminator could have been anything other than
a string. However, other string method calls are checked, so check this
one too.
diff --git a/Modules/_elementtree.c b/Modules/_elementtree.c
index 06ae24c..3dd5c26 100644
--- a/Modules/_elementtree.c
+++ b/Modules/_elementtree.c
@@ -327,8 +327,10 @@
if (attrib != Py_None) {
- if (element_new_extra(self, attrib) < 0)
+ if (element_new_extra(self, attrib) < 0) {
+ PyObject_Del(self);
return NULL;
+ }
self->extra->length = 0;
self->extra->allocated = STATIC_CHILDREN;