commit c7f543520161b895796a571881da74e805d0b1eb
author Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> Fri Aug 24 12:13:57 2018 -0400
committer GitHub <noreply@github.com> Fri Aug 24 12:13:57 2018 -0400
tree 79f987a4c9ce85e67a4e062a0a9457f756978482
parent 3e6020c4ddf7acea91efdae770320c6ce06b93db

closes bpo-34471: _datetime: Add missing NULL check to tzinfo_from_isoformat_results. (GH-8869)


Reported by Svace static analyzer.
(cherry picked from commit 498845368ff0f6238750ab1d443e7cf4ec98ccd2)

Co-authored-by: Alexey Izbyshev <izbyshev@ispras.ru>

Modules/_datetimemodule.c

diff --git a/Modules/_datetimemodule.c b/Modules/_datetimemodule.c
index 91d6991..41b95b9 100644
--- a/Modules/_datetimemodule.c
+++ b/Modules/_datetimemodule.c
@@ -1290,8 +1290,11 @@
         }
 
         PyObject *delta = new_delta(0, tzoffset, tz_useconds, 1);
+        if (delta == NULL) {
+            return NULL;
+        }
         tzinfo = new_timezone(delta, NULL);
-        Py_XDECREF(delta);
+        Py_DECREF(delta);
     } else {
         tzinfo = Py_None;
         Py_INCREF(Py_None);