commit ca1b66fd059758bbd6e2cc62c8f2adecefe8f942
author Denis Osipov <osipov_d@list.ru> Thu Jun 08 17:02:05 2017 +0500
committer Victor Stinner <victor.stinner@gmail.com> Thu Jun 08 14:02:05 2017 +0200
tree f440b7db3f4f8aac8b39c0a28d3d49c7af16b1ea
parent 854f7ba1d5cbb6a42511beae66c8dbe34f2cbcd3

[3.6] bpo-30584: Fix test_os fails on non-English Windows (GH-1980) (#1999)

* Fix bpo-30584

* Adding a comment mentionning the bpo and explaining what is the identifier

* Add Denis Osipov to Misc/ACKS
(cherry picked from commit 897bba75632dfce87c355e3cd4700468357715a7)

Lib/test/test_os.py

diff --git a/Lib/test/test_os.py b/Lib/test/test_os.py
index e9fdb07..46ad209 100644
--- a/Lib/test/test_os.py
+++ b/Lib/test/test_os.py
@@ -473,7 +473,9 @@
         # force CreateFile to fail with ERROR_ACCESS_DENIED.
         DETACHED_PROCESS = 8
         subprocess.check_call(
-            ['icacls.exe', fname, '/deny', 'Users:(S)'],
+            # bpo-30584: Use security identifier *S-1-5-32-545 instead
+            # of localized "Users" to not depend on the locale.
+            ['icacls.exe', fname, '/deny', '*S-1-5-32-545:(S)'],
             creationflags=DETACHED_PROCESS
         )
         result = os.stat(fname)