commit cb5778f00ce48631c7140f33ba242496aaf7102b
author Christian Heimes <christian@python.org> Tue Sep 18 14:38:58 2018 +0200
committer Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> Tue Sep 18 05:38:58 2018 -0700
tree 9905106a1ee7ce94d9fa93b6ac395634c2f24c2f
parent 0185f34ddcf07b78feb6ac666fbfd4615d26b028

bpo-34623: Use XML_SetHashSalt in _elementtree (GH-9146)



The C accelerated _elementtree module now initializes hash randomization
salt from _Py_HashSecret instead of libexpat's default CPRNG.

Signed-off-by: Christian Heimes <christian@python.org>



https://bugs.python.org/issue34623

Modules/_elementtree.c

diff --git a/Modules/_elementtree.c b/Modules/_elementtree.c
index 02781d5..bba6873 100644
--- a/Modules/_elementtree.c
+++ b/Modules/_elementtree.c
@@ -3272,6 +3272,11 @@
         PyErr_NoMemory();
         return -1;
     }
+    /* expat < 2.1.0 has no XML_SetHashSalt() */
+    if (EXPAT(SetHashSalt) != NULL) {
+        EXPAT(SetHashSalt)(self->parser,
+                           (unsigned long)_Py_HashSecret.expat.hashsalt);
+    }
 
     if (target) {
         Py_INCREF(target);