bpo-37207: Use vectorcall for list() (GH-18928)
Speed up calls to list() by using the PEP 590 vectorcall
calling convention. Patch by Mark Shannon.
Co-authored-by: Mark Shannon <mark@hotpy.org>
Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
diff --git a/Misc/NEWS.d/next/Core and Builtins/2019-06-09-10-54-31.bpo-37207.bLjgLS.rst b/Misc/NEWS.d/next/Core and Builtins/2019-06-09-10-54-31.bpo-37207.bLjgLS.rst
new file mode 100644
index 0000000..b6d0236
--- /dev/null
+++ b/Misc/NEWS.d/next/Core and Builtins/2019-06-09-10-54-31.bpo-37207.bLjgLS.rst
@@ -0,0 +1,2 @@
+Speed up calls to ``list()`` by using the :pep:`590` ``vectorcall``
+calling convention. Patch by Mark Shannon.
diff --git a/Objects/listobject.c b/Objects/listobject.c
index 4e2b6a9..91687bc 100644
--- a/Objects/listobject.c
+++ b/Objects/listobject.c
@@ -2719,6 +2719,33 @@
return 0;
}
+static PyObject *
+list_vectorcall(PyObject *type, PyObject * const*args,
+ size_t nargsf, PyObject *kwnames)
+{
+ if (!_PyArg_NoKwnames("list", kwnames)) {
+ return NULL;
+ }
+ Py_ssize_t nargs = PyVectorcall_NARGS(nargsf);
+ if (!_PyArg_CheckPositional("list", nargs, 0, 1)) {
+ return NULL;
+ }
+
+ assert(PyType_Check(type));
+ PyObject *list = PyType_GenericAlloc((PyTypeObject *)type, 0);
+ if (list == NULL) {
+ return NULL;
+ }
+ if (nargs) {
+ if (list___init___impl((PyListObject *)list, args[0])) {
+ Py_DECREF(list);
+ return NULL;
+ }
+ }
+ return list;
+}
+
+
/*[clinic input]
list.__sizeof__
@@ -3034,6 +3061,7 @@
PyType_GenericAlloc, /* tp_alloc */
PyType_GenericNew, /* tp_new */
PyObject_GC_Del, /* tp_free */
+ .tp_vectorcall = list_vectorcall,
};
/*********************** List Iterator **************************/