Fix Coverity warnings.
- Check the correct variable (str_obj, not str) for NULL
- sep_len was already verified it wasn't 0
diff --git a/Objects/stringlib/partition.h b/Objects/stringlib/partition.h
index 8cc7abe..11a12c6 100644
--- a/Objects/stringlib/partition.h
+++ b/Objects/stringlib/partition.h
@@ -58,7 +58,7 @@
)
{
PyObject* out;
- Py_ssize_t pos;
+ Py_ssize_t pos, j;
if (sep_len == 0) {
PyErr_SetString(PyExc_ValueError, "empty separator");
@@ -70,17 +70,12 @@
return NULL;
/* XXX - create reversefastsearch helper! */
- if (sep_len == 0)
- pos = str_len;
- else {
- Py_ssize_t j;
pos = -1;
for (j = str_len - sep_len; j >= 0; --j)
if (STRINGLIB_CMP(str+j, sep, sep_len) == 0) {
pos = j;
break;
}
- }
if (pos < 0) {
Py_INCREF(str_obj);