commit d5c029b1a9b47737efb8966f804d28b99a2de239
author Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> Sat Dec 05 08:24:38 2020 -0800
committer GitHub <noreply@github.com> Sat Dec 05 08:24:38 2020 -0800
tree afd0a802a18af75897fba44d39a4a540fc1a41d4
parent b630ca7bc13ba9bdf95cd7dce0ac8e1578fb53a0

bpo-42576: Raise TypeError when passing in keyword arguments to GenericAlias (GH-23656)


Use `_PyArg_NoKeywords` instead of `_PyArg_NoKwnames` when checking the `kwds` tuple when creating `GenericAlias`. This fixes an interpreter crash when passing in keyword arguments to `GenericAlias`'s constructor.

Needs backport to 3.9.

Automerge-Triggered-By: GH:gvanrossum
(cherry picked from commit 804d6893b801e8f30318afc38c20d4d0e6161db3)

Co-authored-by: kj <28750310+Fidget-Spinner@users.noreply.github.com>

Lib/test/test_genericalias.py

diff --git a/Lib/test/test_genericalias.py b/Lib/test/test_genericalias.py
index 912fb33..c113e53 100644
--- a/Lib/test/test_genericalias.py
+++ b/Lib/test/test_genericalias.py
@@ -302,6 +302,11 @@
                 alias = t[int]
                 self.assertEqual(ref(alias)(), alias)
 
+    def test_no_kwargs(self):
+        # bpo-42576
+        with self.assertRaises(TypeError):
+            GenericAlias(bad=float)
+
 
 if __name__ == "__main__":
     unittest.main()