commit d9d0419a9fc85d1f4c8744f68156fd6b305d5ff0
author Victor Stinner <victor.stinner@gmail.com> Wed Nov 06 23:50:10 2013 +0100
committer Victor Stinner <victor.stinner@gmail.com> Wed Nov 06 23:50:10 2013 +0100
tree 6ced4710eb20f0c4b20d17b5f4d574fc5c039726
parent ae9f161b43df37e69ba4715b50862fdbf077e245

Issue #19512: fileio_init() reuses PyId_name identifier instead of "name"
literal string

Modules/_io/fileio.c

diff --git a/Modules/_io/fileio.c b/Modules/_io/fileio.c
index 27995e5..0e1e709 100644
--- a/Modules/_io/fileio.c
+++ b/Modules/_io/fileio.c
@@ -59,6 +59,8 @@
 
 PyTypeObject PyFileIO_Type;
 
+_Py_IDENTIFIER(name);
+
 #define PyFileIO_Check(op) (PyObject_TypeCheck((op), &PyFileIO_Type))
 
 int
@@ -427,7 +429,7 @@
     _setmode(self->fd, O_BINARY);
 #endif
 
-    if (PyObject_SetAttrString((PyObject *)self, "name", nameobj) < 0)
+    if (_PyObject_SetAttrId((PyObject *)self, &PyId_name, nameobj) < 0)
         goto error;
 
     if (self->appending) {
@@ -1036,7 +1038,6 @@
 static PyObject *
 fileio_repr(fileio *self)
 {
-    _Py_IDENTIFIER(name);
     PyObject *nameobj, *res;
 
     if (self->fd < 0)