Plug memory leak in Py_BuildValue when using {...} to construct dictionaries.
diff --git a/Python/modsupport.c b/Python/modsupport.c
index 12ecaf6..0ddc300 100644
--- a/Python/modsupport.c
+++ b/Python/modsupport.c
@@ -169,6 +169,7 @@
return NULL;
for (i = 0; i < n; i+= 2) {
PyObject *k, *v;
+ int err;
k = do_mkvalue(p_format, p_va);
if (k == NULL) {
Py_DECREF(d);
@@ -180,9 +181,10 @@
Py_DECREF(d);
return NULL;
}
- if (PyDict_SetItem(d, k, v) < 0) {
- Py_DECREF(k);
- Py_DECREF(v);
+ err = PyDict_SetItem(d, k, v);
+ Py_DECREF(k);
+ Py_DECREF(v);
+ if (err < 0) {
Py_DECREF(d);
return NULL;
}