commit e604b6c53e7dce6d4cf52525f4ae57352d489cba
author Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> Fri Nov 30 00:00:07 2018 -0800
committer GitHub <noreply@github.com> Fri Nov 30 00:00:07 2018 -0800
tree 27af9b528733ee9c601dfb8cc2190a4117f0b7a9
parent 8a73cac618a050f4e74eb38ff43e48d9957a6dec

bpo-35356: Fix a possible reference leak in nis.maps(). (GH-10808)

(cherry picked from commit a2e3585e79c93b2372dbad46a744e28fcc6dad6d)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>

Modules/nismodule.c

diff --git a/Modules/nismodule.c b/Modules/nismodule.c
index a9028bb..11df679 100644
--- a/Modules/nismodule.c
+++ b/Modules/nismodule.c
@@ -412,6 +412,7 @@
         PyObject *str = PyUnicode_FromString(maps->map);
         if (!str || PyList_Append(list, str) < 0)
         {
+            Py_XDECREF(str);
             Py_DECREF(list);
             list = NULL;
             break;