commit e8b1ba1699d429b1e80ea7d31032628d09c3e43e
author Christian Heimes <christian@cheimes.de> Sat Nov 23 21:13:39 2013 +0100
committer Christian Heimes <christian@cheimes.de> Sat Nov 23 21:13:39 2013 +0100
tree fadff6adfff7bdb4fa7e38b3e453409229b72715
parent 6188d09f1c27f0ba5d4c369677a308fe118e9d5a

Issue #17810: Add two missing error checks to save_global
CID 1131946:  Unchecked return value  (CHECKED_RETURN)

Modules/_pickle.c

diff --git a/Modules/_pickle.c b/Modules/_pickle.c
index a1819b9..4e0d86c 100644
--- a/Modules/_pickle.c
+++ b/Modules/_pickle.c
@@ -3193,8 +3193,10 @@
         if (self->proto >= 4) {
             const char stack_global_op = STACK_GLOBAL;
 
-            save(self, module_name, 0);
-            save(self, global_name, 0);
+            if (save(self, module_name, 0) < 0)
+                goto error;
+            if (save(self, global_name, 0) < 0)
+                goto error;
 
             if (_Pickler_Write(self, &stack_global_op, 1) < 0)
                 goto error;