commit ee96f32ca24779656d3c8736d26671fc3689f0a3
author Zackery Spytz <zspytz@gmail.com> Thu Jul 09 04:00:21 2020 -0600
committer GitHub <noreply@github.com> Thu Jul 09 03:00:21 2020 -0700
tree bd9e791d38634b225cdee142a0f746c5db8855b5
parent a908bc4dd81f5881280f54b17aae1e7bc450efc9

bpo-41252: Fix incorrect refcounting in _ssl.c's _servername_callback() (GH-21407)

Modules/_ssl.c

diff --git a/Modules/_ssl.c b/Modules/_ssl.c
index 5806417..a8c339d 100644
--- a/Modules/_ssl.c
+++ b/Modules/_ssl.c
@@ -4545,11 +4545,12 @@
          * back into a str object, but still as an A-label (bpo-28414)
          */
         servername_str = PyUnicode_FromEncodedObject(servername_bytes, "ascii", NULL);
-        Py_DECREF(servername_bytes);
         if (servername_str == NULL) {
             PyErr_WriteUnraisable(servername_bytes);
+            Py_DECREF(servername_bytes);
             goto error;
         }
+        Py_DECREF(servername_bytes);
         result = PyObject_CallFunctionObjArgs(
             ssl_ctx->set_sni_cb, ssl_socket, servername_str,
             ssl_ctx, NULL);