commit eea4846d23e2b6967f1e45561603652751b63fbe
author Benjamin Peterson <benjamin@python.org> Mon Jan 16 14:28:50 2012 -0500
committer Benjamin Peterson <benjamin@python.org> Mon Jan 16 14:28:50 2012 -0500
tree 41f763f42f320af15e0831943be775e27daf04e9
parent d120083c144344d1b715fe29f4e74bbc20e8c89f

don't ready in case_operation, since most callers do it themselves

Objects/unicodeobject.c

diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c
index 59fc123..648d9a0 100644
--- a/Objects/unicodeobject.c
+++ b/Objects/unicodeobject.c
@@ -9644,8 +9644,7 @@
     void *data, *outdata;
     Py_UCS4 maxchar = 0, *tmp, *tmpend;
 
-    if (PyUnicode_READY(self) == -1)
-        return NULL;
+    assert(PyUnicode_IS_READY(self));
 
     kind = PyUnicode_KIND(self);
     data = PyUnicode_DATA(self);
@@ -10512,6 +10511,8 @@
 static PyObject*
 unicode_title(PyObject *self)
 {
+    if (PyUnicode_READY(self) == -1)
+        return NULL;
     return case_operation(self, do_title);
 }
 
@@ -12657,6 +12658,8 @@
 static PyObject*
 unicode_swapcase(PyObject *self)
 {
+    if (PyUnicode_READY(self) == -1)
+        return NULL;
     return case_operation(self, do_swapcase);
 }