commit f8c06b028036e50596e75d4c9f6b27ba05133efe
author Alexey Izbyshev <izbyshev@ispras.ru> Wed Aug 22 07:51:25 2018 +0300
committer Serhiy Storchaka <storchaka@gmail.com> Wed Aug 22 07:51:25 2018 +0300
tree a90230adc6372d1fc358b96a4ef612e002ff7b26
parent ef8861c112ed1dac9351958c121bc24ca4ecdb08

bpo-34456: pickle: Add missing NULL check to save_global(). (GH-8851)

Reported by Svace static analyzer.

Modules/_pickle.c

diff --git a/Modules/_pickle.c b/Modules/_pickle.c
index ea778c7..517c99e 100644
--- a/Modules/_pickle.c
+++ b/Modules/_pickle.c
@@ -3454,6 +3454,8 @@
             PickleState *st = _Pickle_GetGlobalState();
             PyObject *reduce_value = Py_BuildValue("(O(OO))",
                                         st->getattr, parent, lastname);
+            if (reduce_value == NULL)
+                goto error;
             status = save_reduce(self, reduce_value, NULL);
             Py_DECREF(reduce_value);
             if (status < 0)